search

beacon-biosignals / Onda.jl

A Julia package for high-throughput manipulation of structured signal data across arbitrary domain-specific encodings, file formats and storage layers
Other
67 stars 5 forks source link

fix bug in hashing samples #151

Closed ericphanson closed 7 months ago

ericphanson commented 7 months ago

The test I added fails on main:

julia> @test hash(samples) == hash(samples2)
Test Failed at REPL[23]:1
  Expression: hash(samples) == hash(samples2)
   Evaluated: 0x9bab1974999310ac == 0x877a3e1403901e84

but passes on this PR.

closes https://github.com/beacon-biosignals/Onda.jl/issues/150

ericphanson commented 7 months ago

The CI failure looks unrelated but concerning

palday commented 7 months ago

I can replicate the CI failure on a local run and it also happens on main. Did an update in Arrow break something?

palday commented 7 months ago

Tests pass on main with Arrow set to 2.6 -- current Arrow release is 2.7.

palday commented 7 months ago

see #153.

This is definitely something that needs to be fixed in upstream Arrow, but we have a work around that's trivial

ericphanson commented 7 months ago

This is definitely something that needs to be fixed in upstream Arrow, but we have a work around that's trivial

Just to say, I don't think there was any bug in the Arrow release, but rather in Onda we were depending on Legolas generating a specific fromarrow method that we stopped generating after https://github.com/beacon-biosignals/Legolas.jl/pull/106, since Samples has some custom serialization as it is not a Legolas @version. Resolved by #153 in any case.