search

beacon-biosignals / Onda.jl

A Julia package for high-throughput manipulation of structured signal data across arbitrary domain-specific encodings, file formats and storage layers
Other
67 stars 5 forks source link

Support `!` for view access #72

Open omus opened 3 years ago

omus commented 3 years ago

Add support for using ! while using getindex to access a view instead of a copy. For example:

samples[channel, !]

People familiar with DataFrames.jl should already be used to this.

There are probably some good reasons not to do this. If so this issue can be useful for future reference.

omus commented 3 years ago

One reason not to do this is that you can't access a view when accessing a single element (e.g. view(sample, channel, 1)

jrevels commented 5 months ago

this is borderline superseded by https://github.com/beacon-biosignals/Onda.jl/issues/77