search

beacon-biosignals / Onda.jl

A Julia package for high-throughput manipulation of structured signal data across arbitrary domain-specific encodings, file formats and storage layers
Other
68 stars 5 forks source link

Implement `broadcastable` for `Samples` #73

Open omus opened 3 years ago

omus commented 3 years ago

By implementing broadcastable(::Samples) we can avoid having to use Ref when using Samples during a broadcast operation (e.g. channel.(Ref(eeg), rows)).

ararslan commented 3 years ago

Don't we only avoid needing to use Ref if we define Samples to broadcast as a scalar? I think I would find it surprising as a user for it to broadcast as a scalar; I think I'd expect it'd broadcast like the type of its data field.

jrevels commented 6 months ago

this is borderline superseded by https://github.com/beacon-biosignals/Onda.jl/issues/77