search

beacon-biosignals / OndaEDF.jl

utilities for importing/exporting EDF Files to/from Onda datasets
Other
3 stars 2 forks source link

EDF labels not preserved in Samples object #86

Open ericphanson opened 1 year ago

ericphanson commented 1 year ago

as claimed by

https://github.com/beacon-biosignals/OndaEDF.jl/blob/fc8709d84e2a55b77cd86d1f9fbc3003d5a95c6d/src/import_edf.jl#L506-L507

That is not possible with Legolas v0.5 / Onda v0.15. I think probably this info needs to be propagated out another way. I do think it's useful info to get.

kleinschmidt commented 1 year ago

Oof, good catch. They're propagated in the plan table (for the reasons you mentioned). We could also define a schema extension which might be a better way to go if we really want to make sure that these labels are always propagated, even if you don't save the plan

ericphanson commented 1 year ago

I think a schema extension wouldn't work since Onda.Samples requires SamplesInfoV2: https://github.com/beacon-biosignals/Onda.jl/blob/dd5d23bd17aab5b07520e40342421829516ef838/src/samples.jl#L52