Handle null-terminated `ObjectRef` fields

omus commented 1 year ago

Potential fix to https://github.com/beacon-biosignals/Ray.jl/issues/177. It appears that the registered address of some ObjectRef is being corrupted most likely through bad CxxWrap handling of null-terminated strings.

I took reviewed our ObjectRef code and found a few places where we convert between StdString and String where a null character could result in an invalid string being produced.

I'll call out I don't know for certain that this will address the problem but it definitely won't hurt.

codecov[bot] commented 1 year ago

Codecov Report

Merging #201 (b4ce181) into main (204dff1) will increase coverage by 0.01%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   95.82%   95.84%   +0.01%     
==========================================
  Files          12       12              
  Lines         623      625       +2     
==========================================
+ Hits          597      599       +2     
  Misses         26       26

Flag	Coverage Δ
Ray.jl	`95.84% <100.00%> (+0.01%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/object_ref.jl	`96.87% <100.00%> (+0.06%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

omus commented 1 year ago

Closing in favor of #203

beacon-biosignals / Ray.jl

Handle null-terminated `ObjectRef` fields #201

Codecov Report