beacon-biosignals / Ray.jl

Julia API for Ray
Other
9 stars 1 forks source link

Wrap `WorkerID` and `NodeID` / robust ID support #209

Closed omus closed 11 months ago

omus commented 11 months ago

While working on expanding the exceptions we handle from the Raylet I found an exception which required us to wrap WorkerID. During implementing this I kept running into the same old issues such as handling == so I decided to refactor this code to be shared among all of he various ID types and also make the code robust.

codecov[bot] commented 11 months ago

Codecov Report

Merging #209 (2a13710) into main (836b43b) will increase coverage by 0.67%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   96.35%   97.02%   +0.67%     
==========================================
  Files          13       13              
  Lines         631      673      +42     
==========================================
+ Hits          608      653      +45     
+ Misses         23       20       -3     
Flag Coverage Δ
Ray.jl 97.02% <100.00%> (+0.67%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/object_ref.jl 100.00% <100.00%> (ø)
src/ray_julia_jll/common.jl 95.39% <100.00%> (+4.40%) :arrow_up:
src/ray_julia_jll/ray_julia_jll.jl 100.00% <ø> (ø)
src/ray_julia_jll/upstream_fixes.jl 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kleinschmidt commented 11 months ago

wanna bump the project.toml since we're doing releases now ;)

omus commented 11 months ago

wanna bump the project.toml since we're doing releases now ;)

Will do.