beacon-biosignals / Ray.jl

Julia API for Ray
Other
9 stars 1 forks source link

Update to use CxxWrap 0.14.1 #217

Closed omus closed 11 months ago

omus commented 11 months ago

This release includes the StdString changes from https://github.com/JuliaInterop/CxxWrap.jl/pull/381 and https://github.com/JuliaInterop/CxxWrap.jl/pull/378 which allows us to drop the safe_convert function which was used to work around the issues noticed with binary string data handling (introduced in https://github.com/beacon-biosignals/Ray.jl/pull/203).

Overall this leads to cleaner code and potentially could fix any lurking issues with StdString binary data we weren't already handling.

Developers running local setups should run this after updating:

julia --project=build -e 'using Pkg; Pkg.update()' && julia --project=build build/build_library.jl && julia --project -e 'using Pkg; Pkg.update(); using Ray'
codecov[bot] commented 11 months ago

Codecov Report

Merging #217 (a71dad2) into main (09c2b9a) will decrease coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
- Coverage   97.02%   96.98%   -0.05%     
==========================================
  Files          13       12       -1     
  Lines         673      663      -10     
==========================================
- Hits          653      643      -10     
  Misses         20       20              
Flag Coverage Δ
Ray.jl 96.98% <100.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Ray.jl 100.00% <ø> (ø)
src/object_ref.jl 100.00% <ø> (ø)
src/ray_julia_jll/common.jl 95.10% <100.00%> (-0.29%) :arrow_down:
src/ray_julia_jll/ray_julia_jll.jl 100.00% <100.00%> (ø)
src/ray_serializer.jl 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more