codecov[bot]
commented
1 year ago Codecov Report
Merging #221 (6edc777) into main (0b75c77) will increase coverage by
0.22%. Report is 2 commits behind head on main. The diff coverage is98.70%.
@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 97.42% 97.64% +0.22%
==========================================
Files 12 12
Lines 660 808 +148
==========================================
+ Hits 643 789 +146
- Misses 17 19 +2 | Flag | Coverage Δ | |
|---|---|---|
| Ray.jl | 97.64% <98.70%> (+0.22%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files | Coverage Δ | |
|---|---|---|
| src/Ray.jl | 100.00% <ø> (ø) |
|
| src/ray_serializer.jl | 100.00% <100.00%> (ø) |
|
| src/runtime.jl | 94.37% <ø> (ø) |
|
| src/exceptions.jl | 98.87% <98.70%> (-1.13%) |
:arrow_down: |
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!
omus
Creates Julia exceptions to mirror the Ray exceptions supported by Ray for Python.
One challenge with porting thing is that some exceptions are MessagePack serialized containing pickle5 data. As we found out in #191 we can somewhat read the content without having to unpack it. I've opted to show users the
repr'd formatted raw data for any exception we haven't seen before. This way users can complain about the bad errors and provide us with examples we can add to our test suites.There is also some future work to be done around adding in call site information from Julia so we can deserialize that information on the driver and report it to the user. I've opted to leave that for now.