search

beacon-biosignals / Ray.jl

Julia API for Ray
Other
11 stars 1 forks source link

Can no longer build core worker library (`ray-2.5.1`) #246

Open omus opened 4 months ago

omus commented 4 months ago

Building the shared library on macOS is failing. When running locally these deprecations are causing failures due to -Werror and trying to add -Wno-deprecated-builtins doesn't seem to apply to these transitive dependencies:

2024-07-04T20:13:00.9507850Z   external/com_google_absl/absl/meta/type_traits.h:301:36: warning: builtin __has_trivial_destructor is deprecated; use __is_trivially_destructible instead [-Wdeprecated-builtins]
2024-07-04T20:13:00.9590050Z       : std::integral_constant<bool, __has_trivial_destructor(T) &&
2024-07-04T20:13:00.9691320Z                                      ^
2024-07-04T20:13:00.9794740Z   external/com_google_absl/absl/meta/type_traits.h:350:36: warning: builtin __has_trivial_constructor is deprecated; use __is_trivially_constructible instead [-Wdeprecated-builtins]
2024-07-04T20:13:00.9893260Z       : std::integral_constant<bool, __has_trivial_constructor(T) &&
2024-07-04T20:13:00.9994270Z                                      ^
2024-07-04T20:13:01.0044070Z   external/com_google_absl/absl/meta/type_traits.h:494:17: warning: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Wdeprecated-builtins]
2024-07-04T20:13:01.0046800Z             bool, __has_trivial_assign(typename std::remove_reference<T>::type) &&
2024-07-04T20:13:01.0048000Z                   ^
2024-07-04T20:13:01.0050140Z   external/com_google_absl/absl/meta/type_traits.h:559:8: warning: builtin __has_trivial_copy is deprecated; use __is_trivially_copyable instead [-Wdeprecated-builtins]
2024-07-04T20:13:01.0055540Z         (__has_trivial_copy(ExtentsRemoved) || !kIsCopyOrMoveConstructible) &&
2024-07-04T20:13:01.0056730Z          ^
2024-07-04T20:13:01.0059800Z   external/com_google_absl/absl/meta/type_traits.h:560:8: warning: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Wdeprecated-builtins]
2024-07-04T20:13:01.0061110Z         (__has_trivial_assign(ExtentsRemoved) || !kIsCopyOrMoveAssignable) &&
2024-07-04T20:13:01.0062880Z          ^
2024-07-04T20:13:01.0064940Z   external/com_google_absl/absl/meta/type_traits.h:559:8: warning: builtin __has_trivial_copy is deprecated; use __is_trivially_copyable instead [-Wdeprecated-builtins]
2024-07-04T20:13:01.0065800Z         (__has_trivial_copy(ExtentsRemoved) || !kIsCopyOrMoveConstructible) &&
2024-07-04T20:13:01.0066160Z          ^
2024-07-04T20:13:01.0067820Z   external/com_google_absl/absl/meta/type_traits.h:571:39: note: in instantiation of template class 'absl::type_traits_internal::is_trivially_copyable_impl<short>' requested here
2024-07-04T20:13:01.0069200Z             bool, type_traits_internal::is_trivially_copyable_impl<T>::kValue> {};
2024-07-04T20:13:01.0069600Z                                         ^
2024-07-04T20:13:01.0072670Z   external/com_google_absl/absl/base/casts.h:155:41: note: in instantiation of template class 'absl::type_traits_internal::is_trivially_copyable<short>' requested here
2024-07-04T20:13:01.0073790Z                     type_traits_internal::is_trivially_copyable<Source>::value &&
2024-07-04T20:13:01.0074510Z                                           ^

On GHA CI these don't seem to have -Werror and instead we see this failure later:

2024-07-04T20:13:10.7593470Z   replication.c:1560:31: error: variable has incomplete type 'struct stat64'
2024-07-04T20:13:10.7593550Z               struct redis_stat buf;
omus commented 4 months ago

Downgrading the compiler doesn't seem like a great option. Probably the best course of action is to upgrade our Ray library to use the latest 2.31.0 release.