search

beacon-biosignals / SlackThreads.jl

Update a running Slack thread with text and attachments.
MIT License
2 stars 1 forks source link

Add DummyThreads as an alternative `AbstractSlackThread` #18

Closed ericphanson closed 2 years ago

ericphanson commented 2 years ago

Closes https://github.com/beacon-biosignals/SlackThreads.jl/issues/14 and provides one option for handling https://github.com/beacon-biosignals/SlackThreads.jl/issues/7

codecov[bot] commented 2 years ago

Codecov Report

Merging #18 (1003318) into main (9a8f30b) will decrease coverage by 0.15%. The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   88.97%   88.81%   -0.16%     
==========================================
  Files           4        5       +1     
  Lines         136      161      +25     
==========================================
+ Hits          121      143      +22     
- Misses         15       18       +3
Impacted Files Coverage Δ
src/SlackThreads.jl 91.48% <ø> (ø)
src/dummy_slack_thread.jl 87.50% <87.50%> (ø)
src/slack_log_exception.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d18c5e8...1003318. Read the comment docs.

ericphanson commented 2 years ago

@omus interested in your thoughts here especially re-#7; this allows DummyThread() as a essentially no-op which could be used as a default value unless a user passes in a live SlackThread.

omus commented 2 years ago

@omus interested in your thoughts here especially re-#7; this allows DummyThread() as a essentially no-op which could be used as a default value unless a user passes in a live SlackThread.

This is a good alternative to what I proposed in #7. One change I'd like to see yet is being able storing the token in the thread struct instead of having to use withenv when I want to specify the Slack token in a different way. That can be done separately.