search

beacon-biosignals / StableHashTraits.jl

Compute hashes over any Julia object simply and reproducibly
MIT License
9 stars 3 forks source link

Implement `UseSize` to avoid reshaped-array hash collision #15

Closed haberdashPI closed 2 years ago

haberdashPI commented 2 years ago

Would close #14

I've assigned this to @kleinschmidt as someone I think would probably be impacted by this change and who hasn't yet had a chance to weigh in on the choice. Feel free to assign someone else who fits that bill Dave if it seems more appropriate.

codecov[bot] commented 2 years ago

Codecov Report

Merging #15 (9e1052d) into main (94b5852) will increase coverage by 0.22%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   97.50%   97.72%   +0.22%     
==========================================
  Files           1        1              
  Lines          80       88       +8     
==========================================
+ Hits           78       86       +8     
  Misses          2        2
Impacted Files Coverage Δ
src/StableHashTraits.jl 97.72% <100.00%> (+0.22%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more