beacon-biosignals / StableHashTraits.jl

Compute hashes over any Julia object simply and reproducibly
MIT License
9 stars 3 forks source link

Simplify `Use_` structs #24

Closed haberdashPI closed 1 year ago

haberdashPI commented 1 year ago

After working on #22 the proliferation of Use_ structs was really starting to bother me, and this weekend I thought of a way to simplify stuff a lot.

The intention would be to merge this before tagging the 1.0 release, to avoid useless churn / breakage between this and #22.

This also takes some structures from setup_tests.jl (TablesEq and ViewsEq) and adds them to the pacakge properly. They are already used in the tests to help exercise various corner-cases I want to avoid bugs in, and they are actually probably useful outside of testing. There were a few gotcha's in getting these to work, so it seemed best to make them available.

codecov[bot] commented 1 year ago

Codecov Report

Merging #24 (f6169d7) into main (a894652) will decrease coverage by 0.59%. The diff coverage is 97.08%.

:exclamation: Current head f6169d7 differs from pull request most recent head 00c5797. Consider uploading reports for the commit 00c5797 to get more accurate results

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   97.82%   97.24%   -0.59%     
==========================================
  Files           1        1              
  Lines          92      145      +53     
==========================================
+ Hits           90      141      +51     
- Misses          2        4       +2     
Impacted Files Coverage Δ
src/StableHashTraits.jl 97.24% <97.08%> (-0.59%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more