Closed haberdashPI closed 9 months ago
Attention: 12 lines
in your changes are missing coverage. Please review.
Comparison is base (
1447160
) 95.97% compared to head (6dec628
) 93.37%.:exclamation: Current head 6dec628 differs from pull request most recent head 8b4d33b. Consider uploading reports for the commit 8b4d33b to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/StableHashTraits.jl | 89.18% | 12 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This has been made obsolete by #46
Description
This creates a hash context (
HashVersion{3}()
) which hashes more type information: it includes a type identifier for all primitive types.It also introduces an optimization to prevent this improvement from slowing down the benchmarks. This optimization elides the type identifier of primitive types in some of the cases where it is redundant. When the eltype or the struct type is included in the hash and is concrete, then the individual collection or struct members do not include their types in the hash, since it is redundant with their container's type.
Before
After