search

beacon-biosignals / StableHashTraits.jl

Compute hashes over any Julia object simply and reproducibly
MIT License
7 stars 1 forks source link

Fix awkward `Pairs` names used to represent keyword arguments #53

Closed haberdashPI closed 7 months ago

haberdashPI commented 7 months ago

Description

The printing of the nameof for keyword arguments varies across julia versions. This PR normalizes the name to be stable across julia versions and sets up a reference test.

NOTE: This is a short term fix to improve the hash stabilit. The long term fix is being discussed over in #50.

Benchmarks

Author, please:

Run the benchmarks under test/benchmarks.jl locally, and update test/benchmark_records.md by inserting a new table at the end of the document with the updated numbers printed at the end of the benchmark script. Place the table as it occurs before and after the application of this PR.

Before

After

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1724ffa) 95.38% compared to head (5398445) 95.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #53 +/- ## ========================================== + Coverage 95.38% 95.41% +0.02% ========================================== Files 2 2 Lines 347 349 +2 ========================================== + Hits 331 333 +2 Misses 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.