Closed haberdashPI closed 4 months ago
@ericphanson is there anything you need from me here? I know this part is still pretty chunky, but I'm not sure how helpful it would be to break up, since the bulk of the changes are in the new implementation of the transformer_traits
which sort of need to be added all together I think...
Attention: Patch coverage is 89.57055%
with 34 lines
in your changes missing coverage. Please review.
Project coverage is 93.50%. Comparing base (
f4259ea
) to head (e57acaa
).
Files | Patch % | Lines |
---|---|---|
src/main_interface.jl | 81.44% | 18 Missing :warning: |
src/transformer_traits.jl | 92.13% | 14 Missing :warning: |
src/hash_traits.jl | 94.11% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Out of curiosity I ran tests on Julia 1.11's RC, and only the latest hash has anything close to all of its tests passing. There's some sort of cursed issue with world age going on in the generated functions in 1.11. So I'm glad we're close to the finish line here. 😅
Description
This implements and documents the core functionality for hash version 4 (StableHashTraits version 1.3). It leaves out all code necessary to cache hash results. It is an intermediate step towards #55.
Remaining TODO:
nameof
(noparentmodule
) and hash functions, type values, null and singletons by default.