Closed haberdashPI closed 3 years ago
One comment: I did look into using an extension of IntervalSets
called IntervalUnionArithmetic, but IntervalSets
assumes the values are <:Real
in its implementation 😞 .
Looks like I pulled the trigger on requesting reviews a little early; there are still a few minor bugs to work out (though I guess that doesn't need to stop someone from looking over what I do have working).
Should be ready for reviews now!
Should be ready for any further reviews, if needed.
Awaiting on discussion #10 to resolve before I make any changes here (since this may move to a PR for Intervals.jl
).
Based on discussion in #10, I'm planning to make a PR to Intervals.jl
with this functionality.
These changes set up some functionality I'm using to generate null annotation labels: e.g. to sample regions of data that have no annotation.
This is still in draft form, working on defining some tests...Base
functionsunion
,intersect
andsetdiff
, etc...TimeSpanUnion
to establish and maintain invariants on the output of set operations; these are read-only arrays of TimeSpansadd(already exists)Base.in
methodBase.rand
overTimeSpan
andTimeSpanUnion
types.extend
method to adjust the endpoint of aTimeSpan
.translateall(!)
andshrinkall(!)
overTimeSpanUnion
objects.