beacon-biosignals / TimeSpans.jl

A Julia package that provides a `TimeSpan` type for representing a continuous span between two points in time.
Other
6 stars 2 forks source link

Set operations and `rand` implementation #11

Closed haberdashPI closed 3 years ago

haberdashPI commented 3 years ago

These changes set up some functionality I'm using to generate null annotation labels: e.g. to sample regions of data that have no annotation.

This is still in draft form, working on defining some tests...

haberdashPI commented 3 years ago

One comment: I did look into using an extension of IntervalSets called IntervalUnionArithmetic, but IntervalSets assumes the values are <:Real in its implementation 😞 .

haberdashPI commented 3 years ago

Looks like I pulled the trigger on requesting reviews a little early; there are still a few minor bugs to work out (though I guess that doesn't need to stop someone from looking over what I do have working).

haberdashPI commented 3 years ago

Should be ready for reviews now!

haberdashPI commented 3 years ago

Should be ready for any further reviews, if needed.

haberdashPI commented 3 years ago

Awaiting on discussion #10 to resolve before I make any changes here (since this may move to a PR for Intervals.jl).

haberdashPI commented 3 years ago

Based on discussion in #10, I'm planning to make a PR to Intervals.jl with this functionality.