search

beacon-biosignals / TimeSpans.jl

A Julia package that provides a `TimeSpan` type for representing a continuous span between two points in time.
Other
6 stars 2 forks source link

Support named tuples and arrow serialization #41

Open haberdashPI opened 2 years ago

haberdashPI commented 2 years ago

These two features were pirated in another beacon repo, and are being moved here

haberdashPI commented 2 years ago

@ericphanson: I believe this is ready for you to approve.

haberdashPI commented 2 years ago

Though there is some debate over in #42 about whether TimeSpans should support non Period values at all...

haberdashPI commented 2 years ago

Okay. I think that should be safe enough now...

ericphanson commented 2 years ago

Sorry, I don't think I'll get to this by my EOD and I'm out of the rest of the week, so I'll unrequest myself. The version #s and right way to align this with changes to Onda still isn't totally clear to me. E.g. Onda is not compatible with v0.3 of TimeSpans.jl which is a complication here.

haberdashPI commented 2 years ago

Onda is not compatible with v0.3 of TimeSpans.jl which is a complication here

In some ways I think that makes the process a little easier: if we mark this release as breaking then Onda can release a breaking version that requires 0.4 of TimeSpans (skipping 0.3 altogether).

What work is involved in making Onda compatible with newer versions of TimeSpans?

ericphanson commented 2 years ago

https://github.com/beacon-biosignals/Onda.jl/issues/123

haberdashPI commented 2 years ago

Alternatively, if Onda is not compatible with 0.3 at all, we can just mark this as non-breaking (since the only reason it is technically "breaking" for Onda is that it was pirating some methods that belonged here).

Whenever Onda gets upgraded to support TimeSpans 0.3, it will have to also remove the methods it pirates.

haberdashPI commented 2 years ago

https://github.com/beacon-biosignals/Onda.jl/issues/123

Thanks that's helpful background! Looks like there are a number of moving parts to supporting TimeSpans 0.3 unrelated to the pirated methods. (Annoyingly that probably needs to be fixed for us to benefit from TimeSpans, since Onda is probably a common dependency).