beacon-biosignals / julia_pod

k8s native julia development
MIT License
10 stars 3 forks source link

BUG: julia_pod assumes AWS_USER_ID is set #55

Open schlichtanders opened 1 year ago

schlichtanders commented 1 year ago

thank you so much for this julia dev environment.

I just got it working locally, however I needed to change the following line: https://github.com/beacon-biosignals/julia_pod/blob/main/add_me_to_your_PATH/julia_pod#L151

SECRET_NAME=$(echo "${AWS_USER_ID}" | tr '[:upper:]' '[:lower:]' | sed -e 's/[^a-z0-9]\+/-/g')

Here AWS_USER_ID is used, however I am connecting to a local minikube instead of AWS, hence AWS_USER_ID does not make sense. I replaced it for myself locally with the following, but I don't know much about kubernetes yet, hence maybe this secret name does not make sense.

SECRET_NAME=$(echo "${KUBERNETES_NAMESPACE}_GITHUB_TOKEN_SECRET" | tr '[:upper:]' '[:lower:]' | sed -e 's/[^a-z0-9]\+/-/g')

can you take a look and change the secret name?