Currently, the interface environment variables are set in accounts.sh. This has a couple disadvantages:
you cannot easily package and install julia_pod as a package, because this would require changing the accounts.sh at the install location, which is usually not easily accessible by the end-user (or my even be read-only)
there is already a good place for Environment Variables, namely in your shell setup (or similar), having accounts.sh creates an extra place for environment variables, while we could reuse the existing conventions
My suggestion: Prefix all the interface environment variables with JULIA_POD_, so that they can easily be set globally in a shell setup. For instance
Currently, the interface environment variables are set in accounts.sh. This has a couple disadvantages:
My suggestion: Prefix all the interface environment variables with
JULIA_POD_
, so that they can easily be set globally in a shell setup. For instanceKUBERNETES_NAMESPACE
->JULIA_POD_KUBERNETES_NAMESPACE
KUBERNETES_SERVICEACCOUNT
->JULIA_POD_KUBERNETES_SERVICEACCOUNT
IMAGE_REPO
->JULIA_POD_IMAGE_REPO
JULIA_VERSION
->JULIA_POD_JULIA_VERSION
CUDA_VERSION
->JULIA_POD_CUDA_VERSION
GITHUB_TOKEN_FILE
,PRIVATE_REGISTRY_URL
, ..., all those which can be set by the end-user