beagan-svg
commented
3 years ago Thanks for the feed back! Suggestions noted ༼ つ ◕_◕ ༽つ
Open vandanakr20 opened 3 years ago
beagan-svg
commented
3 years ago Thanks for the feed back! Suggestions noted ༼ つ ◕_◕ ༽つ
Hi Beagan!
Your test input and output files look great! The only thing is that they should be in the TEST-INPUT/OUPUT folder one level up. I really liked your use of a flow chart, it makes the logic very easy to follow! I think you used a very interesting approach by indexing the input files to extract the indexes. When you open the input files in the second step, are you planning on saving each record or just the parts that you need for the output files? I also think your pseudocode could be a little more clear about what is considered 'bad'. Other than that, I think you did a really good job! Your functions also look like they fit into your code nicely! I especially like the idea of your hamming function to compare the indexes and errore correct indexes with Ns in them!