search

beagle-dev / beagle-lib

general purpose library for evaluating the likelihood of sequence evolution on trees
MIT License
125 stars 57 forks source link

Is libhmsbeagle no longer versioned? #182

Closed thanasibakis closed 1 year ago

thanasibakis commented 1 year ago

Hi!

I'm trying to have beagle 4.0.0 added to homebrew (version 3.1.2 is already there), but the homebrew admins noticed that a change in the versioning for libhmsbeagle broke the mrbayes package on homebrew.

Quoting from Homebrew/homebrew-core#106781:

Looks like libhmsbeagle is no longer versioned. Previously it was libhmsbeagle.1.dylib. Now, it is libhmsbeagle.dylib, and that's broken mrbayes. Would you know if this is intentional?

This issue is actually pretty typical of a build system change, so I suspect that it is not.

The admins would like to check if this was intentional. Could you please help us out?

Thanks in advance!

msuchard commented 1 year ago

This was not intentional, and a patch to our new cmake build files would be much appreciated.

thanasibakis commented 1 year ago

Thanks for the quick reply! I just made a pull request. Admittedly I'm pretty new to working with cmake, so hopefully this patch helps, but please let me know if something could be corrected.

thanasibakis commented 1 year ago

Hi, just wanted to check in and see if the patch looks okay!

chenrui333 commented 1 year ago

ping @msuchard, 🙏

msuchard commented 1 year ago

i think you solved it!

thanasibakis commented 1 year ago

Glad to hear! A quick favor to ask as a follow-up: would you be willing to publish a new "release" on the repo with this commit, so I can have beagle 4 added to homebrew? (No need to have a .pkg or .msi built, the source code archive should be sufficient for this purpose.)