search

beagleboard / am335x_pru_package

331 stars 181 forks source link

Fix warning/error message format to be standard format. #60

Closed hzeller closed 6 years ago

hzeller commented 7 years ago

The standard format for error messages all common compilers in the unix environment use is

  <filename>:<line-number>: <message>

This is easily recongized by IDEs to quickly jump to the source code position.

The previous format was non-standard, so required extensive configuration for editors to be recognized. So let's keep it simple.

hzeller commented 7 years ago

It looks like @giuliomoro modified this line before, but changed it to have a prefix pasm: which made this even worse (and the commit message does not say why).

So I argue that the standard format that every compiler spits out by default is the best. I really like to jump from error message to error message in my editor, previously, this was more or less a manual process...

giuliomoro commented 7 years ago

That pasm: was used for my specific application, but I must have mistakenly committed it as part of my PR perhaps (which was addressing sending errors and warnings to stderr and printing the content of the line where the error happened). Apologies for that. In fact the reason why I needed it for my application is to allow easier error parsing by our custom IDE. So yeah, more than happy to have warning/error messages in standard format!

hzeller commented 7 years ago

Did you get a chance to look at this @jadonk ?