beagleboard / bonescript

Scripting tools for the BeagleBoard and BeagleBone
http://beagleboard.org
MIT License
32 stars 9 forks source link

What is the pinMode for Analog Read? #23

Open jadonk opened 6 years ago

jadonk commented 6 years ago

From @julianduque on April 22, 2014 8:52

Getting the following error using b.INPUT:

/usr/lib/node_modules/bonescript/index.js:195
        throw('Invalid pin object for pinMode: ' + pin);
                                                 ^
Invalid pin object for pinMode: [object Object]

Copied from original issue: jadonk/bonescript#80

jadonk commented 6 years ago

I can fix it to ignore pinMode on analogReads. As far as I could tell from the Arduino API, it isn't used, but I could be wrong. Anyway no need to do it.

On Tue, Apr 22, 2014 at 4:52 AM, Julian Duque notifications@github.comwrote:

Getting the following error using b.INPUT:

/usr/lib/node_modules/bonescript/index.js:195 throw('Invalid pin object for pinMode: ' + pin); ^ Invalid pin object for pinMode: [object Object]

— Reply to this email directly or view it on GitHubhttps://github.com/jadonk/bonescript/issues/80 .

jadonk commented 6 years ago

From @julianduque on April 23, 2014 17:20

Yes, I ended up ignoring it, was tempted to send a PR with the following check in pinMode

if (pin.ain) {
  return;
}

And avoid the crash, what do you think?

jadonk commented 6 years ago

That sounds like a good patch to add. I've been doing an fairly extensive re-write and have been trying to figure out if I push out the re-write before doing a bug-fix release.

jadonk commented 6 years ago

From @julianduque on April 24, 2014 17:4

@jadonk go with the rewrite first :)