jharvell
commented
6 years ago Kernel details:
https://github.com/beagleboard/linux.git
commit 17ceea78d1fc0c6883297ba3d261b5d6f3c976b3 (tag: 4.14.37-ti-r46, bb/4.14)
Author: Robert Nelson <robertcnelson@gmail.com>
Date: Thu Apr 26 15:37:56 2018 -0500
4.14.37-ti-r46 bb.org_defconfig (plus debugging changes)
4.14 TI Delta: https://github.com/RobertCNelson/ti-linux-kernel/compare/19d05d51d321cf13295e8a75c2ab3a62ec91220f...ed7732d6de03523b123073dedf6aaf89733d8d96
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
debugging changes:
jharvell@wolfhound of$ git --no-pager diff 4.14.37-ti-r46
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index 7f8cc5c1f426..2a111ea24f8a 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -454,7 +454,10 @@ static int of_fill_overlay_info(struct of_overlay *ov,
{
ovinfo->overlay = of_get_child_by_name(info_node, "__overlay__");
if (ovinfo->overlay == NULL)
+ {
+ pr_debug("Failed to find child with name __overlay__ for node %s\n", info_node->name);
goto err_fail;
+ }
ovinfo->target = find_target_node(ov, info_node, ov->target_index);
if (ovinfo->target == NULL)
@@ -565,7 +568,10 @@ static int of_build_overlay_info(struct of_overlay *ov,
ovinfo->attrs[1] = NULL;
/* NOTE: direct reference to the full_name */
- ovinfo->attr_group.name = kbasename(ovinfo->info->full_name);
+ if(ovinfo->info == NULL)
+ pr_debug("No info found for child node %d of %d for node %s\n", i, cnt, tree->name);
+ else
+ ovinfo->attr_group.name = kbasename(ovinfo->info->full_name);
ovinfo->attr_group.attrs = ovinfo->attrs;
}
RobertCNelson
pdp7
Kernel Oops triggered on a Beaglebone Black by the following action:
Kernel oops below is from 4.14.37-ti-r46 (https://github.com/beagleboard/linux.git) plus minor unrelated debugging changes that I will detail in a separate comment. The bug is caused by calling sysfs_create_groups with a kobject that has a NULL sysfs directory entry (kobj-sd). I looked at the commit that introduced the call to sysfs_create_groups in April, 2015, and it looks like it would hit this bug every time.
The overlay I am adding is very simple, and I will provide details on that in another comment also.