search

beagleboard / meta-beagleboard

Support for beagleboard.org devices
MIT License
71 stars 63 forks source link

Modify emmc.sh to change USR0 blink during flash operation #7

Closed jadonk closed 11 years ago

jadonk commented 11 years ago

I've applied merges to keep the beagleboard/meta-beagleboard changes to bonescript and bone101 intact. Please consider applying this change.

koenkooi commented 11 years ago

Remove the useless merges and send a seperate pull request for the bone101/bonescript stuff.

NAK on the emmc change, that only makes things worse.

jadonk commented 11 years ago

How on Earth does it make anything worse? Not knowing the flasher is running is worse than knowing it started.

koenkooi commented 11 years ago

It introduces non-standard behaviour for the LEDs with no real benefit. If you want to use the LEDs to mark flasher progress something more elaborate will be needed, e.g.

boot:

USR0: emmc access USR1: off USR2: off USR3: off

emmc.sh starts:

USR0: emmc access USR1: blink USR2: off USR3: off

bootloaders are in place, untarring rootfs starts:

USR0: emmc access USR1: on USR2: blink USR3: off

rootfs untarred, nspawn starts:

USR0: emmc access USR1: on USR2: on USR3: blink

all done, successfull flash:

USR0: on USR1: on USR2: on USR3: on

all done, error encountered:

USR0: off USR1: off USR2: off USR3: off

That would be clearer than replacing a blinking LED with a slightly different blinking LED