search

beagleboard / pocketbeagle

BeagleBoard.org PocketBeagle - ultra small, ultra flexible, ultra affordable
https://beagleboard.org/pocket
Creative Commons Attribution 4.0 International
276 stars 73 forks source link

Sanitized schematic. #10

Closed hemalchevli closed 6 years ago

hemalchevli commented 6 years ago

Removed "Pin not connected" errors. Net labels terminate on wire endpoints. Fixed P1 P2 symbol pin number overlap. Added schematic heading.

jadonk commented 6 years ago

Hey @mwelling, can you confirm this?

mwelling commented 6 years ago

@jadonk all of the changes appear to be fine. The most marked improvement being removal of the text overlaps on the connectors.

Acked-by: Michael Welling mwelling@ieee.org

mwelling commented 6 years ago

We may want to update the schematic pdf in the plots directory to reflect these changes.

hemalchevli commented 6 years ago

I'll raise another PR for the same.

hemalchevli commented 6 years ago

Looks like I cant open another PR from same branch. Good news is the updated PDF is now in the list of files changed. Merging this PR will update the PDF as well.

mwelling commented 6 years ago

Okay @jadonk this should be good to merge now with my ack.