search

beagleterm / beagle-term

Beagle Term for Serial Communication
BSD 3-Clause "New" or "Revised" License
58 stars 26 forks source link

Add options for data bit, parity, stop bit, and flow control #58

Closed codewithtyler closed 8 years ago

codewithtyler commented 8 years ago

Fixes #44.

This code was tested by connecting to a Cisco 1811 router.

sunglim commented 8 years ago

@RandomlyKnighted overall, it looks good. I'll update slightly and send PR to your repository(https://github.com/RandomlyKnighted/beagle-term). It's 10:52 am here,Seoul. and you probably live in east US. I'll send PR at tonight. so that you can see the PR at your morning in your time. Is that OK ? :)

codewithtyler commented 8 years ago

@sunglim Yeah that's fine. You're 13 hours ahead of me. It's 9:07PM here.

In your PR can you test to see if the values are saved when you hit the connect button? When I switched to jQuery's prop function the values quit saving and I'm not sure what I did something wrong.

sunglim commented 8 years ago

Yep sure!! Thank you for your understanding.

CLAassistant commented 8 years ago

CLA assistant check
All committers have signed the CLA.

codewithtyler commented 8 years ago

@sunglim just merged your changes and they now show up in this PR.

Kinda odd though how it asks you for the CLA. I assumed anyone that's a member of the organization wouldn't have to sign it yet.

sunglim commented 8 years ago

I really appreciate your effort!

codewithtyler commented 8 years ago

Happy to help.