search

beagleterm / beagle-term

Beagle Term for Serial Communication
BSD 3-Clause "New" or "Revised" License
58 stars 26 forks source link

Make JSHint automatically via CI #59

Closed sunglim closed 8 years ago

sunglim commented 8 years ago

Since Gruntfile.js already checks JSHint. So runing grunt task via CI is enough.

codewithtyler commented 8 years ago

There's already a JSHint ready to use in the Gruntfile.js. Are you wanting it to run automatically via CI or do you mean something else with this issue?

sunglim commented 8 years ago

Are you wanting it to run automatically via CI or do you mean something else with this issue?

via CI.

I'm going to create something like /tools/run-all-js-test.py that runs jshint for all directories. and run it via CI. Thank you for your comment. Feel free to share any idea.

PS. grunt is good when we write code. but when we review a code we need to see the jshint result.

codewithtyler commented 8 years ago

In some of the open source project's I've worked on in the past we've just made the CI run the grunt task. By doing it that way any jshint errors will show up as a failed check on the PR. The PR can't be merged until it passes the check. It's pretty much the same concept as your CLA bot.

You can also integrate jscsrc with jshint to enforce the Google Style Guide.

sunglim commented 8 years ago

Thank for the info, It sounds like we can run grunt task on CI. I updated issue description.