beakerbrowser / beaker

An experimental peer-to-peer Web browser
https://beakerbrowser.com/
MIT License
6.75k stars 545 forks source link

Tabs from last session are not restored #1884

Open karroffel opened 3 years ago

karroffel commented 3 years ago

Describe the Bug

When using the "Show tabs from your last session" option, any open tabs will not appear after closing and re-opening Beaker.

Background tabs however will still be there after opening beaker again, just non-background tabs are lost.

This happens for me with the "Let Beaker run in the background" option on or off.

To Reproduce

  1. Open Beaker
  2. Go to the general settings page
  3. Set "Show tabs from your last session" option
  4. Open https://duckduckgo.com/ and put it in the background
  5. Open https://duckduckgo.com/ and leave it in the foreground
  6. Close Beaker
  7. Open Beaker again
  8. Notice that the homepage is shown, the previous tab is lost and the background tabs are still there

Expected Behavior

After opening the browser again the tabs that were open before closing last time should appear again.

Screenshots

Peek 2020-12-16 22-22

Environment

Additional Context

Electron: 11.0.0-beta.18 Chromium: 87.0.4280.27 Node: 12.18.3 Hyperspace API: 1.13.0

Also I see two warnings like this in the console:

WARNING: attempted to update state of a tab not on the window
WARNING: attempted to update state of a tab not on the window
da2x commented 3 years ago

This is a duplicate of issue #12.