Closed pfrazee closed 6 years ago
Maybe a setting for rendering images inline that allows a few different levels of privacy:
There could also be an opt-in next to images so you could change the setting without having to navigate to the main Settings page (and so that new users would understand why images aren't embedding automatically).
I'd be interested in building this feature if it was too time-consuming for y'all, I'd love to learn more about how updating sitewide preferences works.
This would be fantastic. If you're up for it, we'd love to have you do it!
I like the idea of making it easy for new users to find out that the image embed setting exists. I'm not sure how I'd do that UI element, but I trust your judgement.
Paul and I are talking about how to store settings right now...we're not sure yet. You probably don't want to publish settings on the profile, because that will someday include sensitive info (like words you've muted, for example). Then again localStorage
isn't a great option because then the user needs to update their settings each time they try a new client.
Ok, we decided it's not acceptable to publish settings on user profiles. Even though image embed settings aren't sensitive, we don't want to set a bad precedent for the future.
Let's store a JSON.stringify
-ed object in localStorage.settings
. This means that anytime you switch clients, you'll lose your settings, but there are ways to make that less painful:
localStorage
@SaFrMo FYI I added app.updateSettings
when I implemented the theme color setting.
That all sounds good to me! Here's a snapshot of the work I managed to get done today - I'll be able to wrap up in the next day or two.
Closed by #25
Allowing image embeds from HTTP/S makes it possible to pixel-track users. Arguably it does for dat:// sites too.
The most paranoid policy would be to only render images from dats that you're following.
We should decide how we want to approach this.