search

beam-community / avro_ex

An Avro Library that emphasizes testability and ease of use.
https://hexdocs.pm/avro_ex/AvroEx.html
67 stars 27 forks source link

Build pipeline #21

Closed doomspork closed 4 years ago

doomspork commented 5 years ago

Ready for review! This PR does a few things for the project:

  1. Remove unnecessary Docker and Avro assets. If/when we support avsc file parsing -> schema generation, we can add assets them with the latest tools shipping with Avro.
  2. Add Dialyzer. This cause an unused cased I was able to remove.
  3. Add Credo and incorporate it's feedback
  4. Add TravisCI to run tests, Dialyzer, and Credo.
doomspork commented 5 years ago

@gerbal you've been contributing a bunch recently, any thoughts on this PR?

doomspork commented 5 years ago

@michaelstalker the existing files weren't included in the release so anyone using the package would have been using them from the repo.

CJ mentioned they had plans to one day support generation of the schema from AVCS on compilation, I think this may have been part of that effort.

doomspork commented 5 years ago

Any thoughts on this @beam-community/avro_ex? I want to get this merged in so we can cut a new release for #23

CJPoll commented 4 years ago

Your hunch about the test avsc files is correct - I had hoped to make a code generator and they were the first step towards that. They were also useful when testing things manually before writing automated tests, especially before I knew how I wanted to deserialize things. I have no qualms about removing them.