search

beam-community / avro_ex

An Avro Library that emphasizes testability and ease of use.
https://hexdocs.pm/avro_ex/AvroEx.html
67 stars 27 forks source link

Allow empty strings as namespaces #80

Closed jbruggem closed 2 years ago

jbruggem commented 2 years ago

Fix #79 by allowing an empty string as a valid value for a namespace.

jbruggem commented 2 years ago

There's a failing test on master (test/property_test.exs:5). It seems related to the latest merged changes, and it didn't seem trivial to fix so I left it as is.

Note that it seems to fail on an assertion:

# assertion
    true = acc_bits < max_bits

I feel like raising instead would make for more understandable error messages.