search

beam-community / bamboo

Testable, composable, and adapter based Elixir email library for devs that love piping.
https://hex.pm/packages/bamboo
MIT License
1.91k stars 345 forks source link

feat: Add arbitrary header overrides for attachments #631

Open jarrodmoldrich opened 3 years ago

jarrodmoldrich commented 3 years ago

This allows bamboo adapters to be accept overriding headers for special use cases. Updates to those adapters would be required to use this functionality.

For e.g., in the specific use-case of adding inlined attachments, some special case headers are required. Now it's possible to add X-Attachment-Id and override the Content-Disposition header with inline to permit the proper display of inlined content, without an email client showing them as explicit attachments for the user to download.

Closes #502 #430

Related PRs: https://github.com/kalys/bamboo_ses/pull/43 https://github.com/DockYard/elixir-mail/pull/137

doomspork commented 2 months ago

Hi @jarrodmoldrich! Now that BEAM Community is taking over Bamboo we're working through these older PRs. Would you like to update this PR or should we close?

jarrodmoldrich commented 2 months ago

@doomspork Hi there! I probably won't be testing this against SES as I've retired the infra I was using, but I'll get the PR up-to-date and to a working state in the coming weeks.

doomspork commented 2 months ago

Amazing, thank you @jarrodmoldrich!

jarrodmoldrich commented 2 weeks ago

@doomspork This is ready for another look (assuming it passes your CI)