beam-community / bamboo

Testable, composable, and adapter based Elixir email library for devs that love piping.
https://hex.pm/packages/bamboo
MIT License
1.9k stars 343 forks source link

SendGrid's root level custom_args is currently unsupported #634

Closed dariushoule closed 1 year ago

dariushoule commented 2 years ago

Hello,

Sendgrid's v3 mail send endpoint supports custom_args at the root level, but bamboo's SendGridAdapter/Helper look like they only support it on the personalization level. Hoping to see something like with_custom_args at the root level (similar to with_unique_args which seems to be only usable in mail send v2?).

Refactoring to use personalizations isn't a great option for my project at the moment.

I'd be willing to contribute a pull request if you guys agree this is a useful addition.

Cheers! 🎉

brian-penguin commented 1 year ago

closed by https://github.com/thoughtbot/bamboo/pull/647