Support private custom args

beam-community / bamboo

Testable, composable, and adapter based Elixir email library for devs that love piping.

https://hex.pm/packages/bamboo

MIT License

1.9k stars 343 forks source link

Support private custom args #647

Closed bernardocaputo closed 1 year ago

bernardocaputo commented 1 year ago

According to sendgrid's documentation, sendgrid's v3 endpoint do not support unique_args:

Therefore, this PR removes all code related to put/with unique_args and changes it to put/with custom_args

peloycosta commented 1 year ago

I came across this PR while searching how to send the custom_args with Bamboo. I think it's important to have this merged as unique_args are deprecated on v3. There also an open issue on this #634. @germsvel is there any way to help move this forward? 🙏

germsvel commented 1 year ago

Hi @peloycosta. Thanks for the inquiry! Unfortunately, I no longer maintain bamboo. I'll reach out to people at thoughtbot to see who is maintaining bamboo these days.

brian-penguin commented 1 year ago

Hey all! We are a little short on Elixir maintainership at thoughtbot these days. We are discussing how to migrate these libraries to a community run initiative at the moment. I'm happy to merge this and cut a release version