beam-community / bamboo

Testable, composable, and adapter based Elixir email library for devs that love piping.
https://hex.pm/packages/bamboo
MIT License
1.91k stars 345 forks source link

assert_email_delivered_with has verbose failure output #659

Closed ghost closed 1 month ago

ghost commented 1 year ago
  defp flunk_attributes_do_not_match(params_given, params_received) do
    """
    The parameters given do not match.

      Parameters given:

        #{inspect(params_given)}

      Email received:

        #{inspect(params_received)}
    """
  end

When you encounter an email failure that uses the helper above, the "Email received:" portion of the failure consumes a lot of space in the error message. Maybe only "Parameters given" should be shown by default and advanced users can provide an additional argument to request verbose output?

github-actions[bot] commented 2 months ago

This issue has been automatically marked as "stale:discard". We are sorry that we haven't been able to prioritize it yet. If this issue still relevant, please leave any comment if you have any new additional information that helps to solve this issue. We encourage you to create a pull request, if you can. We are happy to help you with that.

github-actions[bot] commented 1 month ago

Closing this issue after a prolonged period of inactivity. If this issue is still relevant, feel free to re-open the issue. Thank you!