search

beam-community / bamboo

Testable, composable, and adapter based Elixir email library for devs that love piping.
https://hex.pm/packages/bamboo
MIT License
1.9k stars 343 forks source link

Fix Elixir 1.17 warning about function call without parens #664

Closed michallepicki closed 1 week ago

michallepicki commented 1 month ago

In e3d20799fdc07a67acb068bff65bbe4e07c41e88 I've fixed a warning about invoking a function without parentheses. It shows at run-time and looks like this:

warning: using map.field notation (without parentheses) to invoke function Bamboo.TestAdapter.supports_attachments?() is deprecated, you must add parentheses instead: remote.function()
  (bamboo 2.3.0) lib/bamboo/mailer.ex:307: Bamboo.Mailer.validate_attachment_support/2
  (bamboo 2.3.0) lib/bamboo/mailer.ex:289: Bamboo.Mailer.validate_and_normalize/2
  (bamboo 2.3.0) lib/bamboo/mailer.ex:240: Bamboo.Mailer.deliver_later/3
yordis commented 2 weeks ago

Hey @doomspork, I do not have the proper permission to help folks with this repo. Could you help me with it?

doomspork commented 2 weeks ago

@yordis should be fixed! Separately, but related to related to CI (approved it to run btw), I want to work with you and @btkostner to standardize it across the org, including releases (see: https://github.com/beam-community/common-config). Hopefully reduce some of the overhead

yordis commented 2 weeks ago

I want to work with you and @btkostner to standardize it across the org

That is my intent, for sure. The owner role helps to unblock me cleaning things up to get to the final state 😄 I am trying to adopt the same workflow in Tesla.