search

beam-community / bamboo

Testable, composable, and adapter based Elixir email library for devs that love piping.
https://hex.pm/packages/bamboo
MIT License
1.91k stars 345 forks source link

Compilation Warning in lib/mix/start_sent_email_viewer_task.ex #665

Open the-destro opened 5 months ago

the-destro commented 5 months ago 
warning: Plug.Adapters.Cowboy.http/3 is deprecated. Use Plug.Cowboy.http/3 instead
  lib/mix/start_sent_email_viewer_task.ex:12: Mix.Tasks.Bamboo.StartSentEmailViewer.run/1
WillRochaThomas commented 5 months ago

If anyone is already setup as a contributor and fancied addressing this, I think this line just needs to change, so it might be straightforward.

change this

Plug.Adapters.Cowboy.http(Bamboo.SentEmailViewerPlug, [], port: 4003)

to

Plug.Cowboy.http(Bamboo.SentEmailViewerPlug, [], port: 4003)

If I find the time to get setup, I might do it myself, just a bit maxed out right now.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as "stale:discard". We are sorry that we haven't been able to prioritize it yet. If this issue still relevant, please leave any comment if you have any new additional information that helps to solve this issue. We encourage you to create a pull request, if you can. We are happy to help you with that.

doomspork commented 1 month ago

@WillRochaThomas @the-destro we'd love PRs from the community now that @beam-community/team is taking over these repos from Thoughtbot. The more help the better for all of us using Elixir!