The url_for_pagination function throws an error when supplied a nested filter - Githubissues

beam-community / jsonapi

JSON:API Serializer and Query Handler for Elixir

https://hex.pm/packages/jsonapi

MIT License

490 stars 79 forks source link

The url_for_pagination function throws an error when supplied a nested filter #283

Open theirishpenguin opened 1 year ago

theirishpenguin commented 1 year ago

The Problem

When I supply a nested filter for an index request - eg. /movies?filter[price][lt]=49 Then I get the error...

Suspected Cause

The problem appears to be that URI.encode_query/1, which ultimately gets called, does not like nested fields (such as "lt" nested under "price")
Some efforts to mitigate this already appear to have been taken at https://github.com/beam-community/jsonapi/blob/52c700ddf303d5d61077c8e8bbe051b3334b40fb/lib/jsonapi/view.ex#L339
- ... however this mitigation falls short when there are multiple level nested query params

github-actions[bot] commented 1 week ago

This issue has been automatically marked as "stale:discard". We are sorry that we haven't been able to prioritize it yet. If this issue still relevant, please leave any comment if you have any new additional information that helps to solve this issue. We encourage you to create a pull request, if you can. We are happy to help you with that.