search

beam-community / jsonapi

JSON:API Serializer and Query Handler for Elixir
https://hex.pm/packages/jsonapi
MIT License
490 stars 79 forks source link

Allow conditionally hidden fields #313

Open protestContest opened 4 months ago

protestContest commented 4 months ago

The hidden/0 view callback is handy to remove sensitive fields in views. In some cases, an API may want to hide certain fields by default, but show them in some cases (in my application's case, some fields should be visible if specifically requested as part of a sparse fieldset).

It would be handy if the hidden callback accepted conn as an argument, so the application could decide what fields to hide for a particular request.

Any thoughts on this? I'm happy to open a PR for the change.

Related issue: #68

mattpolzin commented 4 months ago

that sounds like a reasonable solution as long as you don't need to omit any relationships (really, anything outside of attributes) conditionally. just cuz the hidden/0 function only operates on fields to begin with.

github-actions[bot] commented 1 week ago

This issue has been automatically marked as "stale:discard". We are sorry that we haven't been able to prioritize it yet. If this issue still relevant, please leave any comment if you have any new additional information that helps to solve this issue. We encourage you to create a pull request, if you can. We are happy to help you with that.