search

beam-community / stripity-stripe

An Elixir Library for Stripe
Other
966 stars 346 forks source link

Add back `Subscription.delete` #753

Closed inooid closed 1 year ago

inooid commented 1 year ago

Description

It seems that with the Stripe API version upgrade we accidentally deleted the way for subscriptions to be cancelled. The Stripe API docs (and their SDK) still mention the subscription.del(). This PR is just a recovery of the previous version &delete/1, &delete/2 and &delete/3 methods (minus the deprecated params).

Note: I have stripped off the deprecated params as they are also not referenced in the docs anymore 👍

Fixes https://github.com/beam-community/stripity_stripe/issues/750

snewcomer commented 1 year ago

@inooid Mind bringing in the latest with a CI fix so we can get this PR green?

inooid commented 1 year ago

@snewcomer for sure! I am currently feeling a bit under the weather, so if you feel like it needs to be wrapped up asap then please go ahead and make another PR to update it by yourself 👍 If you want to wait until I am recovered (hopefully next 1-2 days 🤞) I'll wrap it up myself 👌