search

beam-community / stripity-stripe

An Elixir Library for Stripe
Other
965 stars 346 forks source link

Implement object_name_to_module so it will work for new objects in future #792

Closed sb8244 closed 9 months ago

sb8244 commented 1 year ago

This fixes #790 #817 #791 in a way that will also work for the future.

fixes #790 #817 #791

doomspork commented 1 year ago

@sb8244 seems as a result of merging #790 we've caused a merge conflict. Would you mind taking a look at that?

sb8244 commented 1 year ago

@doomspork merged back with main 👍

doomspork commented 1 year ago

Thank you @sb8244, appreciate the multiple PRs this weekend! 🙏 Random but noticed you're a fellow Atlantian (is that a thing?) 🎉

@snewcomer this change looks good to me but I'd like to defer to you for final review/approval.

sb8244 commented 1 year ago

Wow unexpected! Not too many of us in the Elixir community.

github-actions[bot] commented 11 months ago

This pull request has been automatically marked as "stale:discard". If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated!.

sb8244 commented 11 months ago

bump

yordis commented 11 months ago

@sb8244 I will be helping you move forward. Would you mind rebasing the PR? My apologies for the inconvenience.

arosenb2 commented 9 months ago

Any chance this could get merged conflicts resolved and then merged + have a new release cut? I'm looking to use Financial Connections with webhooks and this PR seems like it would fix that.

sb8244 commented 9 months ago

Thanks for handling @yordis