search

beam-community / stripity-stripe

An Elixir Library for Stripe
Other
965 stars 344 forks source link

Add :phone_number_collection to create_params #803

Closed objectuser closed 9 months ago

objectuser commented 1 year ago

This adds the phone_number_collection field to create_params in Stripe.Session.

This is intended to be applied against the 2.17.x line.

yordis commented 1 year ago

There is a merger conflict

objectuser commented 1 year ago

Is there a branch from which the 2.17.x releases are being cut? It looks like main is tracking a fundamental change to the lib.

yordis commented 1 year ago

As far as I can tell, we should use main. We are generating a few stuff from it: https://github.com/beam-community/stripity-stripe/blob/5360e587ce025f7ec37ce3dcb714b4d5ad9f8911/.github/workflows/codegen.yml#LL6C13-L6C13

Related to this: https://github.com/beam-community/stripity-stripe/issues/802

I am trying to get help to release the lib since it is fundamentally a bit different from the source code and hasn't been released for a while now.

objectuser commented 1 year ago

Yeah, seems like it's not in a state for PRs or releases. Maybe a fork from the last release point might be needed.

yordis commented 1 year ago

@objectuser the good part is that I am also using the package so I have direct skin in the game. I am gonna wait to see if I get some help with the releasing and then focus on getting the package to a stable state.

objectuser commented 1 year ago

Kinda seems like this should be forked from the point of the last functional version.

github-actions[bot] commented 10 months ago

This pull request has been automatically marked as "stale:discard". If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated!.