search

beam-community / stripity-stripe

An Elixir Library for Stripe
Other
965 stars 344 forks source link

Telemetry #809

Closed gsychev closed 11 months ago

gsychev commented 12 months ago

@yordis I don't quite understand the request. :telemetry.span is already adding start, stop and exception

yordis commented 12 months ago

I am an idiot! 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 I just realized you did what I asked you to do 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 (alright I need to rest before code reviewing things, my apologies)

gsychev commented 12 months ago

@yordis, so what do you think about this PR?

yordis commented 12 months ago

I am in ElixirConf this week. Let me get back to you after it. Thus far looks good