Fix Stripe.File.create - Githubissues

aymanosman commented 4 months ago

It seems that this library was building the wrong url, ending in /v1//v1/files. This was fixed by changing the config variable api_upload_url.
The test for file upload was skipped, presumably because stripe-mock used not to support it. It does now, so I've enabled the test and fixed it.
Lastly, I changed an existing test which is failing for me, but I'm not sure if this will break other people's tests. It is in test/stripe/subscriptions/credit_note_test.exs and it only involves the order of query parameters. Hopefully this fix is stable.

yordis commented 4 months ago

CI is failing hhhhmmm

aymanosman commented 4 months ago

CI is failing hhhhmmm

Seems unrelated to this PR. Also failing in this PR.

Error is something to do with the erlexec application.

yordis commented 4 months ago

Would you mind digging into it? Otherwise, I could follow up on by the end of the next week (if I do not forget*)

aymanosman commented 3 months ago

I'll take a look

aymanosman commented 3 months ago

@yordis I've found the problem, please take a look at this PR https://github.com/beam-community/stripity-stripe/pull/839

yordis commented 3 months ago

Rebase and we go to go

yordis commented 3 months ago

🚀 💜

beam-community / stripity-stripe