Elixir 1.17 warnings - Githubissues

Rio517 commented 2 months ago

Existing Issue or Pull Request Verification

[X] Confirmed, no existing Issues or Pull Requests found related to my submission.

Package Version

3.2.0

Are you using the latest version?

[X] Yes, I verified the issue is still present in the latest version.

Steps to Reproduce

This is just a deprecation issue that isn't popping up since 1.17 isn't in the ci.yml test matrix.

Create an app in Elixir 1.17
Call PetalPro.Billing.Customers.create_customer_for_source

Expected Result

Smooth operation.

Actual Result

warning: using map.field notation (without parentheses) to invoke function Stripe.Customer.__struct__() is deprecated, you must add parentheses instead: remote.function()
(stripity_stripe 3.2.0) lib/stripe/converter.ex:41: Stripe.Converter.convert_stripe_object/1
(stripity_stripe 3.2.0) lib/stripe/request.ex:204: Stripe.Request.make_request/1
(my_app 2.0.0) lib/my_app/billing/providers/stripe/services/find_or_create_customer.ex:17: MyApp.Billing.Providers.Stripe.Services.FindOrCreateCustomer.create_customer/3
(my_app 2.0.0) lib/my_app/billing/providers/stripe.ex:16: MyApp.Billing.Providers.Stripe.checkout/4
(my_app 2.0.0) lib/my_app_web/controllers/subscribe_controller.ex:47: MyAppWeb.SubscribeController.handle_checkout/4
(my_app 2.0.0) lib/my_app_web/controllers/subscribe_controller.ex:1: MyAppWeb.SubscribeController.action/2
(my_app 2.0.0) lib/my_app_web/controllers/subscribe_controller.ex:1: MyAppWeb.SubscribeController.phoenix_controller_pipeline/2
(phoenix 1.7.14) lib/phoenix/router.ex:484: Phoenix.Router.__call__/5
(my_app 2.0.0) lib/my_app_web/endpoint.ex:1: MyAppWeb.Endpoint.plug_builder_call/2
(my_app 2.0.0) lib/my_app_web/endpoint.ex:1: MyAppWeb.Endpoint.call/2
(phoenix 1.7.14) lib/phoenix/test/conn_test.ex:225: Phoenix.ConnTest.dispatch/5
test/my_app_web/controllers/subscribe_controller_test.exs:18: MyAppWeb.SubscribeControllerTest."test GET /app/checkout/:plan_slug as an org"/1
(ex_unit 1.17.2) lib/ex_unit/runner.ex:485: ExUnit.Runner.exec_test/2
(stdlib 6.0.1) timer.erl:590: :timer.tc/2
(ex_unit 1.17.2) lib/ex_unit/runner.ex:407: anonymous fn/6 in ExUnit.Runner.spawn_test_monitor/4

Gladear commented 1 month ago

I see this was fixed in https://github.com/beam-community/stripity-stripe/pull/840, would it be possible to release a new version, please?

Gladear commented 1 month ago

@yordis Sorry to bother you, but is there something preventing the release of a new version of this package? If so, can I help with it?

yordis commented 1 month ago

There is indeed, https://github.com/beam-community/stripity-stripe/pull/853 and I take any help provided, it is grunt work, but still, work

beam-community / stripity-stripe