search

beam-telemetry / cowboy_telemetry

Telemetry instrumentation for Cowboy
Apache License 2.0
30 stars 9 forks source link

dependencies too strict causing issues #10

Closed epinault closed 2 years ago

epinault commented 2 years ago

I think we might want to loosen up the dependencies like other libs

Failed to use "telemetry" (versions 0.4.0 to 0.4.2) because
  db_connection (version 2.4.1) requires ~> 0.4 or ~> 1.0
  deps/absinthe/mix.exs requires ~> 0.4.0
  ecto (version 3.7.1) requires ~> 0.4 or ~> 1.0
  ecto_sql (version 3.7.1) requires ~> 0.4.0 or ~> 1.0
  new_relic_agent (version 1.27.6) requires ~> 0.4 or ~> 1.0
  phoenix (version 1.5.13) requires ~> 0.4 or ~> 1.0
  phoenix_live_view (version 0.17.3) requires ~> 0.4.2 or ~> 1.0
  plug (version 1.12.1) requires ~> 0.4.3 or ~> 1.0
  redix (version 1.1.4) requires ~> 0.4.0 or ~> 1.0
  telemetry_metrics (version 0.6.1) requires ~> 0.4 or ~> 1.0

Failed to use "telemetry" (version 0.4.3) because
  cowboy_telemetry (version 0.4.0) requires ~> 1.0
  db_connection (version 2.4.1) requires ~> 0.4 or ~> 1.0
  deps/absinthe/mix.exs requires ~> 0.4.0
  ecto (version 3.7.1) requires ~> 0.4 or ~> 1.0
  ecto_sql (version 3.7.1) requires ~> 0.4.0 or ~> 1.0
  new_relic_agent (version 1.27.6) requires ~> 0.4 or ~> 1.0
  phoenix (version 1.5.13) requires ~> 0.4 or ~> 1.0
  phoenix_live_view (version 0.17.3) requires ~> 0.4.2 or ~> 1.0
  plug (version 1.12.1) requires ~> 0.4.3 or ~> 1.0
  redix (version 1.1.4) requires ~> 0.4.0 or ~> 1.0
  telemetry_metrics (version 0.6.1) requires ~> 0.4 or ~> 1.0
josevalim commented 2 years ago

Unfortunately we can't express ~> 0.4 or ~> 1.0 in Rebar3, which is why we released it with ~> 1.0. But you should be able to force this project to a certain version so resolution works.

epinault commented 2 years ago

sure. This change came with the update for live_dashboard. So it seems to force downgrading telemetry and cowboy_telemetry because absinthe require 0.4.0. Maybe I can ask absinthe to support 1.0 ?

Upgraded:
  castore 0.1.11 => 0.1.13
  earmark_parser 1.4.16 => 1.4.17
  phoenix_live_view 0.17.3 => 0.17.5
Downgraded:
  cowboy_telemetry 0.4.0 => 0.3.1 (minor)
  telemetry 1.0.0 => 0.4.3 (major)
* Updating phoenix_live_dashboard (Hex package)
* Updating mime (Hex package)
* Updating phoenix_live_view (Hex package)
* Updating phoenix_html (Hex package)
* Updating castore (Hex package)
* Updating earmark_parser (Hex package)
josevalim commented 2 years ago

Maybe I can ask absinthe to support 1.0 ?

Sounds like a good plan!