Add telemetry_test - Githubissues

beam-telemetry / telemetry

Dynamic dispatching library for metrics and instrumentations.

https://hexdocs.pm/telemetry

Apache License 2.0

872 stars 66 forks source link

Add telemetry_test #118

Closed whatyouhide closed 1 year ago

whatyouhide commented 2 years ago

Hey friends!

I find myself doing this constantly. I think it would be good to have something built-in just for the sake of inviting people to test their telemetry events 😄

I threw a PR together since I thought it'd be easier to talk about something concrete, but I’m not attached to API or implementation here.

Thoughts?

arkgil commented 1 year ago

Thanks, I like that!

whatyouhide commented 1 year ago

@arkgil thanks for the review! I addressed your comments, waiting on CI now.

whatyouhide commented 1 year ago

@arkgil anything I can do to push this over the finish line? 🙃

arkgil commented 1 year ago

@whatyouhide apologies, I was on holiday. Would you mind adding version-type: strict below this line https://github.com/beam-telemetry/telemetry/blob/dc1cf9e0d71739485272fb38cec6e96b5e6bdfe9/.github/workflows/test.yml#L27 to see if this fixes the CI for other versions? Unless I'm missing something and it's not the reason for failure.

whatyouhide commented 1 year ago

@arkgil done 👍

arkgil commented 1 year ago

@whatyouhide I fixed the CI in https://github.com/beam-telemetry/telemetry/pull/120, after that's merged can you please rebase your PR on top of main? Thanks!

josevalim commented 1 year ago

Can we include examples of how a test would look like in Erlang and Elixir? Something like attach, execute and assert_receive in Elixir. :)

whatyouhide commented 1 year ago

@josevalim added examples 👍

@arkgil rebased 🙃