search

beam-telemetry / telemetry

Dynamic dispatching library for metrics and instrumentations.
https://hexdocs.pm/telemetry
Apache License 2.0
872 stars 66 forks source link

Release 1.0.0 #71

Closed arkgil closed 3 years ago

arkgil commented 3 years ago

The new version of rebar3 handles dependency versions with an or (see https://github.com/erlang/rebar3/pull/2370), so dependencies relying on telemetry will be able to use ~> 0.4 or ~> 1.0.

(cc'ing @tsloughter to make sure that I haven't got ☝️ wrong, but it seems to be working with rebar3 3.14.4 in my tests).

We can safely mark 1.0.0 now!

Closes #69

tsloughter commented 3 years ago

@arkgil no, rebar3 does not support that. It was reverted.

arkgil commented 3 years ago

Thanks for double checking @tsloughter. Putting this on hold for now.

josevalim commented 3 years ago

Should we resume this? Btw, does ~> 0.4 or ~> 1.0 even matter for Rebar? Won't Rebar just pick the latest anyway?

wojtekmach commented 3 years ago

Please remember to also update https://github.com/beam-telemetry/telemetry/blob/a2e98a6474212a518fd1406d457e39839ae51e0b/docs.sh#L12

arkgil commented 3 years ago

does ~> 0.4 or ~> 1.0 even matter for Rebar? Won't Rebar just pick the latest anyway?

@tsloughter any thoughts on this? What do we risk if we release before Rebar supports the or syntax?

tsloughter commented 3 years ago

@arkgil rebar3 will be unable to build any project that uses telemetry with that version constraint.

arkgil commented 3 years ago

@josevalim in that case how about we simply make all the projects depend on ~> 1.0? I guess it only matters for the poller, it's the only one that is built by rebar.

josevalim commented 3 years ago

I think it is fine for the poller to depend on the 1.0 version, yeah. I guess the Elixir projects are fine to depend on any version and that should not affect rebar.

tsloughter commented 3 years ago

Technically it will effect rebar since with a plugin you can build mix deps and people do. But it is already a problem so not really a blocker.

wojtekmach commented 3 years ago

Please run ./docs.sh and rebar3 hex docs

and lmk if you run into any issues.

arkgil commented 3 years ago

@wojtekmach pinged you in the Elixir Slack.