search

beam-telemetry / telemetry_metrics

Collect and aggregate Telemetry events over time
https://hexdocs.pm/telemetry_metrics
Apache License 2.0
207 stars 33 forks source link

Add a console reporter #37

Closed josevalim closed 5 years ago

josevalim commented 5 years ago

Closes #36.

codecov-io commented 5 years ago

Codecov Report

Merging #37 into master will decrease coverage by 1.52%. The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   98.07%   96.55%   -1.53%     
==========================================
  Files           1        2       +1     
  Lines          52       87      +35     
==========================================
+ Hits           51       84      +33     
- Misses          1        3       +2
Flag Coverage Δ
#1_5_otp18 96.51% <94.11%> (-1.57%) :arrow_down:
#1_5_otp20 96.51% <94.11%> (-1.57%) :arrow_down:
#1_8_otp20 96.55% <94.28%> (-1.53%) :arrow_down:
#1_8_otp22 96.55% <94.28%> (-1.53%) :arrow_down:
Impacted Files Coverage Δ
lib/telemetry_metrics.ex 98.07% <ø> (ø) :arrow_up:
lib/telemetry_metrics/console_reporter.ex 94.28% <94.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25325a1...1626385. Read the comment docs.

arkgil commented 5 years ago

@josevalim Looks good to me! I've left one comment for discussion :)

josevalim commented 5 years ago

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart: